chore: cargo clippy --fix 清理 small lints (closes #170 第一波)#171
Merged
Conversation
cargo clippy --fix 自动修了 8 个 lint，warnings 从 18 降到 16。 改动文件： - asr/mod.rs / coordinator.rs / hotkey.rs / insertion.rs / polish.rs / types.rs - 主要是 needless_borrow / single_match / useless_conversion / 多余 cast build 跑过： - cargo check ✅ - npm run build ✅ 剩余 16 个 warning 都是有意保留的（test-only helpers、future-API placeholder、 类似 TodayMetrics 这种历史接口），不动这些避免破坏 surface。issue #170 里更深层的整洁度（SettingsWriter dedupe / force 参数删除等）后续 PR 跟进。
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
Closes #170 的第一波——cargo clippy --fix 能自动修的 8 个 lint。
改动
测试
备注
issue #170 提到的更深层整洁度（SettingsWriter trait dedupe、Settings.tsx 的 `force` 参数删除、Linux 文案补齐）留下个 PR 跟进。本 PR 仅自动 lint。
@codex review 一下吧。