Skip to content

fix(windows): 收紧主窗口 shell 外观契约#181

Merged
appergb merged 4 commits into
Open-Less:mainfrom
Cooper-X-Oak:codex/windows-native-titlebar-off
May 2, 2026
Merged

fix(windows): 收紧主窗口 shell 外观契约#181
appergb merged 4 commits into
Open-Less:mainfrom
Cooper-X-Oak:codex/windows-native-titlebar-off

Conversation

@Cooper-X-Oak
Copy link
Copy Markdown
Contributor

治理归属

  • 族群:A 族群 / 窗口外观契约
  • canonical issue:[Windows][P1] 主窗口四周圆角与自绘外框贴合不完整 #127
  • 主修范围:主窗口圆角、外框、titlebar、shadow、首帧 shell 贴合
  • 不默认并入:capsule geometry、helper-window 生命周期、QA helper-window 语义、双热键事件源
  • 参考:
    • docs/windows-window-governance-board.zh-CN.md
    • docs/2026-05-02-window-capability-family-audit.md
    • docs/github-tracking/windows-window-family-canonical-map.md

摘要

Closes #127

这条 PR 承接 Windows 主窗口 shell 外观契约修复。
本轮重点是把:

  • frameless shell
  • custom titlebar
  • outer shell radius / inner console radius
  • Windows resize affordance

收敛成同一条主窗口外观线,不再和 capsule geometry、helper-window lifecycle 混修。

修复 / 新增 / 改进

  • 收紧 WindowChrome.tsx 的 Windows shell / titlebar / button / resize handle 契约
  • FloatingShell.tsx 消费 shared console radius,而不是单独硬编码 Windows 半径
  • tauri.conf.json 的 main window 收口到 frameless create
  • 扩充 windows-ui-config.test.mjs,锁住主窗口外观契约

兼容

  • 不包含:Capsule geometry / clipping / distortion
  • 不包含:helper-window lifecycle ownership
  • 不包含:startup visible / ready ownership
  • 对现有用户 / 本地环境 / 构建流程的影响:只聚焦 Windows main shell 外观线

测试计划

  • node openless-all/app/scripts/windows-ui-config.test.mjs
  • npm run build
  • cargo check --manifest-path openless-all/app/src-tauri/Cargo.toml
  • powershell -ExecutionPolicy Bypass -File openless-all/app/scripts/windows-build-gnu.ps1
  • powershell -ExecutionPolicy Bypass -File openless-all/app/scripts/windows-open-dev.ps1 -ExePath <GNU dev exe>
  • Windows 100% / 125% DPI 人工视觉回归

说明

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Cooper-X-Oak, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@appergb appergb force-pushed the codex/windows-native-titlebar-off branch from fd5466c to 802ee65 Compare May 2, 2026 04:13
@Cooper-X-Oak
Copy link
Copy Markdown
Contributor Author

自动 Windows 实机回归新增 blocker:\n\n- fresh-start 后通过 windows-open-dev.ps1 复核,进程能启动,但主窗口句柄对应矩形稳定落在 Left=0, Top=0, Right=5, Bottom=5\n- 同时窗口标题表现为 com.openless.app-siw,不是预期的正常主界面标题\n- 这说明当前分支并未达到可进入人工视觉贴合回归的前提,属于更前置的起窗/可见窗口异常\n\n因此这条 PR 不应继续保持 ready 状态,已退回 draft,建议先修复这个 blocker,再继续做四角/外框/titlebar 视觉评审。

@Cooper-X-Oak Cooper-X-Oak marked this pull request as draft May 2, 2026 04:14
@appergb appergb marked this pull request as ready for review May 2, 2026 04:18
@appergb appergb merged commit 7aefb81 into Open-Less:main May 2, 2026
2 checks passed
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @appergb, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@Cooper-X-Oak
Copy link
Copy Markdown
Contributor Author

自动 Windows 实机回归更正:\n\n- 之前的 5x5 矩形来自进程关联的一个可见小宿主/辅助窗口,不是实际的主界面窗口\n- 重新枚举进程下全部顶层窗口后,已经确认存在一个真正可见的 Title=OpenLess 主窗口,矩形约为 Left=102, Top=56, Right=1356, Bottom=864\n- 已抓到对应主窗口截图,说明这条分支已经满足进入人工视觉贴合回归的前提\n\n因此,前一条 blocker 评论作废:当前剩余重点重新回到人工 Windows 视觉贴合评审(四角 / 外框 / titlebar / resize 手感 / 100% 和 125% DPI)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows][P1] 主窗口四周圆角与自绘外框贴合不完整

2 participants