恢复 Intel Mac release 构建#317
Conversation
The release matrix had kept Intel macOS disabled because the old macos-13 pool was deprecated and repeatedly stalled releases. GitHub now exposes an explicit Intel runner label, so the release lane can be restored without returning to the unstable macos-13 runner. Constraint: Intel Mac release artifacts must be produced separately from Apple Silicon artifacts Rejected: Re-enable macos-13 | that runner was explicitly disabled due to deprecation and queue instability Confidence: high Scope-risk: narrow Directive: Keep macOS updater artifact names architecture-qualified when multiple darwin lanes are active Tested: git diff --check Tested: Parsed release-tauri.yml matrix and verified macOS arm64/x86_64 lanes plus arch-specific updater paths Not-tested: Full GitHub Actions release run
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
@claude examine 检查有没有严重的问题,审查这个 CI 构建流程在逻辑上是否通顺、是否不会失败。 |
|
Claude finished @appergb's task in 3m 30s —— View job CI 构建流程审查结果
整体结论:逻辑通顺,无严重问题 ✓PR 的变更量极小(+4/-9 行),逻辑正确,可以合入。以下是逐项检查。 检查项详情1. 这是最关键的问题——runner 名称拼错或不存在会导致 job 一直 queue 或立刻失败。确认 2. matrix 变量一致性 ✓ - platform: macos-15-intel
rust-target: x86_64-apple-darwin # ✓ 与 Intel 架构匹配
updater-target: darwin # ✓ 与 arm64 lane 保持一致
updater-arch: x86_64 # ✓ 区分 aarch64三个字段内部自洽,与已有 arm64 lane 形成正确对称。 3. workflow 中所有 macOS 专属步骤(Apple 证书导入、公证配置、 4. artifact 命名不冲突 ✓
两个 macOS job 并行上传到同一个 GitHub Release 时,所有资产名称都带架构后缀,不会互相覆盖。 5. generate_release_notes: ${{ matrix.updater-target == 'darwin' && matrix.updater-arch == 'aarch64' }}现在有两个 darwin job,这个条件确保 release notes 只由 arm64 job 生成一次,x86_64 job 为 6. 脚本直接调用 未发现严重问题无构建失败风险、无 artifact 冲突风险、无逻辑短路风险。可以合入。 |
User description
变更
macos-15-intel+x86_64-apple-darwin,生成darwin/x86_64updater manifest。为什么不是 macos-13
之前 Intel Mac lane 被注释掉,是因为
macos-13runner 已被标记为 deprecated,且队列不稳定,曾经拖住 release run。这次没有恢复旧的
macos-13,而是改用 GitHub 当前明确提供的 Intel macOS runner:macos-15-intel。这样可以恢复 Intel Mac 产物,同时避免回到旧 runner 的排队/弃用风险。验证
git diff --check.github/workflows/release-tauri.ymlmatrix,确认同时包含:macos-latest / aarch64-apple-darwin / darwin aarch64macos-15-intel / x86_64-apple-darwin / darwin x86_64${{ matrix.updater-arch }}区分架构未验证
PR Type
Enhancement
Description
Restore Intel Mac release lane with
macos-15-intelSet
x86_64-apple-darwintarget andx86_64updater archAvoid deprecated
macos-13runner instabilityDiagram Walkthrough
File Walkthrough
release-tauri.yml
Add Intel Mac release lane with macos-15-intel.github/workflows/release-tauri.yml
macos-13matrix entrymacos-15-intelentry withx86_64-apple-darwintarget