fix(windows-ci): WiX 工具按 WixTools* 通配查找,避免 Tauri 升级后路径失效#405
Merged
Conversation
Windows MSI Repair 之前硬编码 `C:\Users\22933\AppData\Local\tauri\WixTools314\light.exe`,Tauri 升级到新 WiX 版本(如 WixTools315)后路径不存在,Repair 步骤直接挂。 改为 WixTools* glob,按数字后缀降序回退到名称降序,取最新可用版本。同步更新 windows-package-msvc.ps1::Find-WixTool 和 release-tauri.yml 的 Repair 步骤;保留 -sice:ICE80、NSIS/MSI 两轮 build、bash shell 等 Windows CI 红线不变。 补 4 条 windows-package-msvc.test.mjs 防回归断言:禁止 WixTools314 出现在脚本/workflow,要求两边都按 WixTools* glob 查找。 Refs: Open-Less#298
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
H-Chris233
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Windows MSI Repair 之前硬编码
C:\Users\22933\AppData\Local\tauri\WixTools314\light.exe,Tauri 升级到新 WiX 版本(如 WixTools315)后路径不存在,Repair 步骤直接挂。改为 WixTools* glob,按数字后缀降序回退到名称降序,取最新可用版本。同步更新 windows-package-msvc.ps1::Find-WixTool 和 release-tauri.yml 的 Repair 步骤;保留 -sice:ICE80、NSIS/MSI 两轮 build、bash shell 等 Windows CI 红线不变。
补 4 条 windows-package-msvc.test.mjs 防回归断言:禁止 WixTools314 出现在脚本/workflow,要求两边都按 WixTools* glob 查找。
Refs: #298
PR Type
Bug fix, Tests
Description
Discover latest
WixTools*automaticallyRepair workflow locates
light.exeby globTests block
WixTools314regressionsKeep MSI repair compatible across Tauri upgrades
Diagram Walkthrough
File Walkthrough
windows-package-msvc.ps1
Discover latest Tauri WiX toolsopenless-all/app/scripts/windows-package-msvc.ps1
LOCALAPPDATA\tauri\WixTools*directories instead ofWixTools314light.exewhen neededrelease-tauri.yml
Resolve WiX tools in workflow.github/workflows/release-tauri.yml
light.exefrom the newestWixTools*directoryWixTools314dependencywindows-package-msvc.test.mjs
Update WiX discovery regression testsopenless-all/app/scripts/windows-package-msvc.test.mjs
WixTools314never appears