Skip to content

Route qwen-asr submodule through organization fork#424

Merged
H-Chris233 merged 1 commit into
Open-Less:mainfrom
H-Chris233:fix/issue-301-qwen-asr-fork
May 12, 2026
Merged

Route qwen-asr submodule through organization fork#424
H-Chris233 merged 1 commit into
Open-Less:mainfrom
H-Chris233:fix/issue-301-qwen-asr-fork

Conversation

@H-Chris233
Copy link
Copy Markdown
Collaborator

@H-Chris233 H-Chris233 commented May 12, 2026

User description

Summary

  • move vendor/qwen-asr submodule URL from the personal upstream repo to Open-Less/qwen-asr
  • keep the submodule pinned at the current reviewed commit b00b789b17051aea61e9717458171100662318a4
  • document the future qwen-asr submodule upgrade review checklist

Closes #301

Verification

  • gh repo view Open-Less/qwen-asr --json nameWithOwner,isFork,parent,defaultBranchRef,updatedAt,url
  • git submodule update --init --recursive openless-all/app/src-tauri/vendor/qwen-asr
  • git diff --check
  • npm run build
  • cargo check --manifest-path src-tauri/Cargo.toml

Not tested

  • macOS INSTALL=0 ./scripts/build-mac.sh C-link verification (not available in this Linux session)

PR Type

Enhancement, Documentation


Description

  • Switch vendor/qwen-asr submodule URL from personal upstream to Open-Less/qwen-asr fork

  • Add docs/qwen-asr-submodule-upgrade-checklist.md with review process and safety steps

  • Update all in-code comments, docs, and CI config to reference the new fork


Diagram Walkthrough

flowchart LR
  A["antirez/qwen-asr (upstream)"] -- "forks to" --> B["Open-Less/qwen-asr"]
  B -- "becomes submodule URL" --> C[".gitmodules"]
  C -- "comment & doc updates" --> D["Rust source files, READMEs, CI"]
  C -- "new file" --> E["docs/qwen-asr-submodule-upgrade-checklist.md"]
Loading

File Walkthrough

Relevant files
Configuration changes
1 files
.gitmodules
Point submodule URL to organization fork `Open-Less/qwen-asr`
+1/-1     
Documentation
12 files
qwen-asr-submodule-upgrade-checklist.md
Add thorough upgrade checklist for qwen-asr submodule       
+49/-0   
build.rs
Update comment to reference `Open-Less/qwen-asr` instead of antirez
+2/-2     
Cargo.toml
Update dependency comments to mention `Open-Less/qwen-asr`
+2/-2     
mod.rs
Adjust module doc to note vendored `Open-Less/qwen-asr` engine
+1/-1     
qwen_engine.rs
Revise doc comments to refer to `Open-Less/qwen-asr` fork
+2/-2     
qwen_ffi.rs
Update FFI doc comment to mention vendored `Open-Less/qwen-asr`
+1/-1     
persistence.rs
Change inline doc from antirez to `qwen-asr` (fork)           
+1/-1     
localAsr.ts
Adjust comment to reference `Open-Less/qwen-asr` engine availability
+1/-1     
release-tauri.yml
Update CI comment about submodule source being `Open-Less/qwen-asr`
+1/-1     
README.md
Replace antirez/qwen-asr with Open-Less/qwen-asr in key descriptions
+2/-2     
README.zh.md
Sync Chinese README with new `Open-Less/qwen-asr` fork reference
+2/-2     
README.md
Update submodule description to point to `Open-Less/qwen-asr`
+1/-1     

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

PR Reviewer Guide 🔍

(Review updated until commit 4d9b63a)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

301 - Partially compliant

Compliant requirements:

  • Regularly sync upstream changes and allow time for commit review before upgrading the submodule.
  • Document the submodule upgrade review checklist.

Non-compliant requirements:

  • Fork the qwen-asr repository to appergb/qwen-asr and update the submodule URL to point to the fork. (The PR points to Open-Less/qwen-asr instead of appergb/qwen-asr; this is likely the correct organization fork as per the issue title "fork 到本组织", but the ticket text mentions appergb. Needs verification.)

Requires further human verification:

  • Whether the fork Open-Less/qwen-asr is the intended organization fork and if the submodule commit matches the reviewed commit.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Keep the submodule pinned to the reviewed commit while moving the fetch URL to Open-Less/qwen-asr, then document the review checklist future upgrades must follow.\n\nConstraint: Open-Less#301 identified the personal upstream submodule URL as a supply-chain risk.\nRejected: Updating the submodule commit together with the URL change | would mix provenance hardening with unreviewed upstream code changes.\nConfidence: high\nScope-risk: narrow\nDirective: Do not point .gitmodules back to antirez/qwen-asr; sync upstream into the organization fork and review the diff first.\nTested: gh repo view Open-Less/qwen-asr; git submodule update --init --recursive openless-all/app/src-tauri/vendor/qwen-asr; git diff --check; npm run build; cargo check --manifest-path src-tauri/Cargo.toml\nNot-tested: macOS INSTALL=0 ./scripts/build-mac.sh C-link verification.
@H-Chris233 H-Chris233 force-pushed the fix/issue-301-qwen-asr-fork branch from 5057477 to 4d9b63a Compare May 12, 2026 10:48
@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit 4d9b63a

@H-Chris233 H-Chris233 merged commit 2bbe111 into Open-Less:main May 12, 2026
4 checks passed
@H-Chris233 H-Chris233 deleted the fix/issue-301-qwen-asr-fork branch May 12, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant