Route qwen-asr submodule through organization fork#424
Merged
H-Chris233 merged 1 commit intoMay 12, 2026
Conversation
PR Reviewer Guide 🔍(Review updated until commit 4d9b63a)Here are some key observations to aid the review process:
|
Keep the submodule pinned to the reviewed commit while moving the fetch URL to Open-Less/qwen-asr, then document the review checklist future upgrades must follow.\n\nConstraint: Open-Less#301 identified the personal upstream submodule URL as a supply-chain risk.\nRejected: Updating the submodule commit together with the URL change | would mix provenance hardening with unreviewed upstream code changes.\nConfidence: high\nScope-risk: narrow\nDirective: Do not point .gitmodules back to antirez/qwen-asr; sync upstream into the organization fork and review the diff first.\nTested: gh repo view Open-Less/qwen-asr; git submodule update --init --recursive openless-all/app/src-tauri/vendor/qwen-asr; git diff --check; npm run build; cargo check --manifest-path src-tauri/Cargo.toml\nNot-tested: macOS INSTALL=0 ./scripts/build-mac.sh C-link verification.
5057477 to
4d9b63a
Compare
|
Persistent review updated to latest commit 4d9b63a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
vendor/qwen-asrsubmodule URL from the personal upstream repo toOpen-Less/qwen-asrb00b789b17051aea61e9717458171100662318a4Closes #301
Verification
gh repo view Open-Less/qwen-asr --json nameWithOwner,isFork,parent,defaultBranchRef,updatedAt,urlgit submodule update --init --recursive openless-all/app/src-tauri/vendor/qwen-asrgit diff --checknpm run buildcargo check --manifest-path src-tauri/Cargo.tomlNot tested
INSTALL=0 ./scripts/build-mac.shC-link verification (not available in this Linux session)PR Type
Enhancement, Documentation
Description
Switch
vendor/qwen-asrsubmodule URL from personal upstream toOpen-Less/qwen-asrforkAdd
docs/qwen-asr-submodule-upgrade-checklist.mdwith review process and safety stepsUpdate all in-code comments, docs, and CI config to reference the new fork
Diagram Walkthrough
File Walkthrough
1 files
Point submodule URL to organization fork `Open-Less/qwen-asr`12 files
Add thorough upgrade checklist for qwen-asr submoduleUpdate comment to reference `Open-Less/qwen-asr` instead of antirezUpdate dependency comments to mention `Open-Less/qwen-asr`Adjust module doc to note vendored `Open-Less/qwen-asr` engineRevise doc comments to refer to `Open-Less/qwen-asr` forkUpdate FFI doc comment to mention vendored `Open-Less/qwen-asr`Change inline doc from antirez to `qwen-asr` (fork)Adjust comment to reference `Open-Less/qwen-asr` engine availabilityUpdate CI comment about submodule source being `Open-Less/qwen-asr`Replaceantirez/qwen-asrwithOpen-Less/qwen-asrin key descriptionsSync Chinese README with new `Open-Less/qwen-asr` fork referenceUpdate submodule description to point to `Open-Less/qwen-asr`