Skip to content

Show elapsed time in recording capsule#430

Closed
Michealmyson wants to merge 5 commits into
Open-Less:betafrom
Michealmyson:codex-capsule-progress-typeless
Closed

Show elapsed time in recording capsule#430
Michealmyson wants to merge 5 commits into
Open-Less:betafrom
Michealmyson:codex-capsule-progress-typeless

Conversation

@Michealmyson
Copy link
Copy Markdown

@Michealmyson Michealmyson commented May 13, 2026

User description

Summary

This is a smaller follow-up to #406, adjusted to match the current typeless capsule processing logic.

Changes:

  • Show elapsed recording time inside the existing recording capsule, e.g. 00:08.
  • Keep the existing recording / transcribing / polishing capsule states unchanged.
  • Do not add a new capsule state or backend processing type.
  • Add i18n keys for the elapsed-time label.
  • Clarify the inserted-count copy with a character unit where needed.

Why

The previous PR added an explicit inserting capsule state, but the latest upstream capsule implementation now favors typeless processing with the existing thinking/insertion flow. This PR keeps that architecture intact and focuses only on the visible user feedback gap during recording.

Verification

  • Ran npm run build successfully.

PR Type

Enhancement


Description

  • Add a recording timer toggle.

  • Show elapsed time in capsule.

  • Clarify inserted character counts.

  • Sync new preference across layers.


Diagram Walkthrough

flowchart LR
  S["Settings panel"] -- "toggle timer" --> P["Preferences"]
  P -- "persist showCapsuleElapsedTime" --> C["Capsule UI"]
  E["Recording events"] -- "update elapsedMs" --> C
  I["Translations"] -- "localize labels" --> C
Loading

File Walkthrough

Relevant files
Configuration changes
2 files
types.rs
Persist capsule timer preference in Rust                                 
+8/-0     
ipc.ts
Include timer preference in mock settings                               
+1/-0     
Enhancement
8 files
Capsule.tsx
Render elapsed recording time in capsule                                 
+79/-4   
en.ts
Add English timer and count strings                                           
+4/-1     
ja.ts
Add Japanese timer and count strings                                         
+3/-0     
ko.ts
Add Korean timer and count strings                                             
+3/-0     
zh-CN.ts
Add Simplified Chinese timer and unit copy                             
+4/-1     
zh-TW.ts
Add Traditional Chinese timer and unit copy                           
+4/-1     
types.ts
Extend preferences with timer flag                                             
+2/-0     
Settings.tsx
Add recording timer toggle to settings                                     
+10/-2   
Tests
1 files
stylePrefs.test.ts
Update preference fixture for new field                                   
+1/-0     

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

PR Reviewer Guide 🔍

(Review updated until commit 3149e39)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

406 - PR Code Verified

Compliant requirements:

  • Show elapsed recording time inside the recording capsule.
  • Keep the existing recording / transcribing / polishing capsule states unchanged.
  • Do not add a new capsule state or backend processing type.
  • Add i18n keys for the elapsed-time label.
  • Clarify the inserted-count copy with a character unit where needed.
  • Sync the new recording-timer preference across the settings UI, persisted preferences, and capsule UI.

Requires further human verification:

  • Verify the capsule layout and spacing with the timer enabled in the real app UI.
  • Verify the preference persists and updates live across the full Tauri event flow.
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@appergb
Copy link
Copy Markdown
Collaborator

appergb commented May 13, 2026

如果没有实际效果图,并且不能提供开关胶囊中显示时间的功能,那么我不会合进你的 PR。你的 PR 需要具备以下内容:

  1. 功能开关
  2. (a) 提供自定义开关该功能状态的能力。
    1. 展示材料
  3. (a) 附带详细的功能展示照片。

@Michealmyson
Copy link
Copy Markdown
Author

已按反馈补充:\n\n1. 新增设置开关:设置 -> 录音 -> 显示录音计时。\n2. 该开关默认关闭,保持现有 capsule 视觉和 typeless capsule processing logic 不变;用户开启后才会在 recording capsule 中显示 elapsed time。\n3. 计时状态会跟随 prefs:changed 同步,用户在设置里切换后无需重启。\n4. 修复了 payload 缺少 elapsedMs 时会把计时重置为 00:00 的问题:现在只在收到 elapsedMs 时更新,idle 时清零。\n5. 已补齐 zh-CN / zh-TW / en / ja / ko 文案。\n\n本地验证:\n- npm run build ✅\n- cargo check --manifest-path src-tauri/Cargo.toml ✅(仅保留项目既有 warning)\n\n后续我会补充实际功能截图,方便 review。

@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit e784e82

@Michealmyson
Copy link
Copy Markdown
Author

补充展示材料:\n\n设置开关:\n\nShow recording timer setting\n\n录音胶囊读秒效果:\n\nRecording capsule elapsed time

@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit 5af7010

@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit 49502e1

@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit 3149e39

@H-Chris233
Copy link
Copy Markdown
Collaborator

@appergb

@appergb
Copy link
Copy Markdown
Collaborator

appergb commented May 14, 2026

? 你确定这是我们的软件吗?你是否拉取了最新的 Beta 测试版本呢?

  1. 软件版本确认
    (a) 这完全不是我们的软件。
    (b) 你根本没有拉取 Beta 测试版本,并且完全不正确。

@appergb appergb closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants