Skip to content

feat(wayland): callout 补全 --toggle-qa / --cancel-dictation#433

Merged
appergb merged 1 commit into
betafrom
feat/wayland-callout-three-commands
May 13, 2026
Merged

feat(wayland): callout 补全 --toggle-qa / --cancel-dictation#433
appergb merged 1 commit into
betafrom
feat/wayland-callout-three-commands

Conversation

@appergb
Copy link
Copy Markdown
Collaborator

@appergb appergb commented May 13, 2026

User description

背景

issue #420 评论里 @aeoform 反馈 1.3.1-19 在 Wayland 下唤醒 OK,但应用内 callout 只展示了 openless --toggle-dictation 一条命令,没有提到 QA 触发用 --toggle-qa、取消用 --cancel-dictation,建议补上。

beta 1.3.1-19_amd64.deb 也没问题,但是应用内提示没写 QA 触发用 --toggle-qa、取消用 --cancel-dictation,建议加上

后端 CLI 三条命令在 1.3.1-18 就已经实现(cli.rs:41-43lib.rs:805-846 完整 dispatch),本次只是前端文案补全。

改动

  • Settings.tsxWaylandHotkeyCallout:单条命令展示 → 三条命令并列,每条独立"复制"按钮 + 右侧用途短标签
  • 三个新 i18n key:commandToggleDictationLabel / commandToggleQaLabel / commandCancelDictationLabel
  • GNOME / KDE 步骤改为"重复添加 1-3 组"
  • Hyprland / sway 步骤给出三行示例(多行通过 whiteSpace: pre-line 渲染)
  • 5 份 i18n 文件(zh-CN / en / zh-TW / ja / ko)全量同步,zh-CN 为 source of truth

零后端改动。

Test plan

  • npm run build(tsc + vite)通过
  • 5 份 i18n 文件 key 形状一致(grep 验证三条新 key 全部到位)
  • 真机视觉验证只能在 Linux Wayland 上做——macOS 下 is_wayland_cli_mode 恒 false,本地无法直接渲染 callout
  • 在 GNOME Wayland 上:callout 展示三行,每行可点击复制对应命令;折叠 help 后 GNOME / KDE 步骤含"1-3 组"提示;Hyprland / sway 步骤含三行 bind 示例

关联

issue #420


PR Type

Bug fix, Enhancement


Description

  • Expand Wayland shortcut guidance

  • Show three CLI commands

  • Add per-command copy feedback

  • Update desktop setup instructions


Diagram Walkthrough

flowchart LR
  Settings["Settings page Wayland callout"]
  I18n["Localized Wayland strings"]
  Commands["Three shortcut commands"]
  Steps["Desktop setup instructions"]

  I18n -- "provides labels and text" --> Settings
  Settings -- "renders" --> Commands
  Settings -- "shows" --> Steps
Loading

File Walkthrough

Relevant files
Enhancement
Settings.tsx
Show multiple Wayland commands                                                     

openless-all/app/src/pages/Settings.tsx

  • Replaces the single Wayland command with three command rows.
  • Adds separate labels for dictation, QA, and cancel actions.
  • Tracks copied state per command to avoid timer overlap.
  • Renders setup help text with preserved line breaks.
+92/-49 
Documentation
zh-CN.ts
Refresh Wayland guidance in Chinese                                           

openless-all/app/src/i18n/zh-CN.ts

  • Expands the Wayland callout body to mention multiple commands.
  • Adds labels for the three command rows.
  • Updates GNOME, KDE, Hyprland, and sway setup steps.
  • Includes multi-line examples for compositor configs.
+8/-5     
en.ts
Update English Wayland instructions                                           

openless-all/app/src/i18n/en.ts

  • Rewords the callout to explain separate shortcut bindings.
  • Adds English labels for all three command actions.
  • Expands desktop-specific setup steps with multi-command guidance.
  • Shows multi-line Hyprland and sway examples.
+8/-5     
ja.ts
Update Japanese Wayland guidance                                                 

openless-all/app/src/i18n/ja.ts

  • Revises the Wayland warning copy for per-command shortcuts.
  • Adds labels for dictation, QA, and cancel commands.
  • Updates GNOME, KDE, Hyprland, and sway instructions.
  • Adds multi-line config examples for Wayland compositors.
+8/-5     
ko.ts
Update Korean Wayland guidance                                                     

openless-all/app/src/i18n/ko.ts

  • Revises the Wayland callout to cover multiple shortcut bindings.
  • Adds labels for the three available commands.
  • Updates desktop setup steps across GNOME, KDE, Hyprland, and sway.
  • Adds multi-line examples for compositor configuration files.
+8/-5     
zh-TW.ts
Refresh Traditional Chinese guidance                                         

openless-all/app/src/i18n/zh-TW.ts

  • Updates the Wayland callout for separate command bindings.
  • Adds labels for dictation, QA, and cancel actions.
  • Revises GNOME, KDE, Hyprland, and sway setup steps.
  • Adds multi-line configuration examples for Wayland desktops.
+8/-5     

#420 评论里 aeoform 反馈 1.3.1-19 在 Wayland 下 callout 只展示 --toggle-dictation
一条,没有提及 QA 触发用 --toggle-qa、取消用 --cancel-dictation。

把单条命令展示改为三条命令并列,每条独立"复制"按钮 + 用途短标签
(开始/停止录音、打开/关闭 QA 面板、取消当前录音)。GNOME / KDE 步骤
改为"重复添加 1-3 组";Hyprland / sway 步骤给出三行示例 + 帮助区
启用 pre-line 渲染多行配置片段。

5 份 i18n 文件(zh-CN 源、en / zh-TW / ja / ko 同步翻译)同步新增三条
label key 并更新步骤文案。后端 CLI 三条命令早已实现(cli.rs:41-43),
本次只补前端提示。
@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

420 - Partially compliant

Compliant requirements:

  • The Wayland callout now shows the dictation, QA, and cancel commands.
  • GNOME and KDE setup instructions now mention repeating the shortcut setup for 1-3 command groups.
  • Hyprland and sway instructions now include all three bind examples.

Non-compliant requirements:

  • The PR does not change any backend or system behavior to make global Wayland shortcuts work directly.

Requires further human verification:

  • The updated callout layout and multiline instructions should be visually checked on a real Linux Wayland session.
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@appergb appergb merged commit 61325e3 into beta May 13, 2026
4 checks passed
@appergb appergb deleted the feat/wayland-callout-three-commands branch May 13, 2026 15:08
appergb pushed a commit that referenced this pull request May 13, 2026
- PR #433:Wayland callout 补全 --toggle-qa / --cancel-dictation
  三命令并列 + 五语言同步翻译
- PR #434:本地 Qwen3-ASR 末段静默 padding 修末 chunk 丢内容;
  动态超时 max(15, ceil(audio_s × 0.6) + 10) 修长录音超时
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant