Skip to content

fix(shell): sidebar 底部翻回两行(版本在上、设置在下)#463

Merged
appergb merged 1 commit into
betafrom
fix/sidebar-footer-two-rows-version-on-top
May 17, 2026
Merged

fix(shell): sidebar 底部翻回两行(版本在上、设置在下)#463
appergb merged 1 commit into
betafrom
fix/sidebar-footer-two-rows-version-on-top

Conversation

@appergb
Copy link
Copy Markdown
Collaborator

@appergb appergb commented May 17, 2026

User description

Summary

PR #462 把底部折成一行后,在窄 sidebar 下「设置」被挤成两行竖字、版本 chip 糊一起 —— 见 #462 合并后的截图。

改回两行但反过来:版本在上、设置在下 —— 设置真正落到最底(符合最初诉求),版本有独立空间容下 BETA 标 + 完整版本号。设置按钮恢复 display:flex + label flex:1,跟上面 nav 按钮风格统一。

Test plan

  • tsc clean
  • 本地装包验证(截图 OK,已在会话中确认)

PR Type

Enhancement, Other


Description

  • Reflow sidebar footer into two rows

  • Keep version chip above settings

  • Restore compact settings button styling

  • Bump app versions to 1.3.4-1


Diagram Walkthrough

flowchart LR
  A["Sidebar footer layout"] -- "reordered into two rows" --> B["Version chip"]
  A -- "settings moved below" --> C["Settings button"]
  D["App metadata"] -- "bumped to" --> E["1.3.4-1 release"]
Loading

File Walkthrough

Relevant files
Enhancement
FloatingShell.tsx
Reorder footer into stacked rows                                                 

openless-all/app/src/components/FloatingShell.tsx

  • Change the sidebar footer from a single row to a vertical stack.
  • Place the version chip above the settings button.
  • Restore the settings button to display: flex with a full-width label.
  • Keep the beta tag and version text in a compact wrap-friendly row.
+26/-26 
Configuration changes
package.json
Bump app package version                                                                 

openless-all/app/package.json

  • Update the app package version from 1.3.3 to 1.3.4-1.
package-lock.json
Sync locked app version                                                                   

openless-all/app/package-lock.json

  • Align the lockfile metadata with the new 1.3.4-1 app version.
Cargo.toml
Bump Tauri package version                                                             

openless-all/app/src-tauri/Cargo.toml

  • Update the Rust/Tauri package version from 1.3.3 to 1.3.4-1.
Cargo.lock
Sync Rust lockfile version                                                             

openless-all/app/src-tauri/Cargo.lock

  • Keep the Rust lockfile aligned with the 1.3.4-1 release bump.
tauri.conf.json
Sync Tauri app version                                                                     

openless-all/app/src-tauri/tauri.conf.json

  • Update the Tauri app version from 1.3.3 to 1.3.4-1.

PR #462 把底部折成一行,结果在窄 sidebar 下「设置」被挤成两行
竖字、版本 chip 糊在旁边,可读性大幅退化。改回两行但反过来:
- 上行:[BETA] 版本 v1.3.4-1(容下 BETA 标 + 完整版本号)
- 下行:⚙ 设置(真正落到最底,符合最初诉求)

设置按钮恢复 display:flex + label flex:1 跟上面 nav 按钮统一风格。
@appergb appergb merged commit 061558a into beta May 17, 2026
4 checks passed
@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

462 - PR Code Verified

Compliant requirements:

  • Reflow the sidebar footer into two rows.
  • Keep the version chip above the settings button.
  • Restore the compact settings button styling.

Requires further human verification:

  • The version bump/alignment across package.json, lockfiles, tauri.conf.json, and Cargo.toml is not visible in the provided diff and should be verified separately.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Layout wrap

The version row now allows wrapping and no longer forces a single line, so on narrow sidebars or in locales with longer labels the BETA tag and version text can split onto multiple lines. That can make the footer taller than expected and undermine the compact two-row layout this change is meant to preserve.

<div style={{ display: 'flex', flexDirection: 'column', gap: 8, paddingTop: 10 }}>
  <div
    style={{
      display: 'flex',
      alignItems: 'center',
      gap: 8,
      flexWrap: 'wrap',
      padding: '0 10px',
      fontFamily: 'var(--ol-font-sans)',
      fontSize: 11,
      color: 'var(--ol-ink-4)',
    }}
  >
    {IS_BETA_BUILD && (
      <span style={{
        display: 'inline-block',
        padding: '2px 8px',
        fontSize: 10,
        fontWeight: 600,
        letterSpacing: '0.04em',
        textTransform: 'uppercase',
        color: 'var(--ol-blue)',
        background: 'rgba(37,99,235,0.10)',
        borderRadius: 999,
      }}>{t('shell.betaTag')}</span>
    )}

    <span>{t('shell.footer.version', { version: APP_VERSION_LABEL })}</span>
  </div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant