Withdrawn

[Cooper-X-Oak]

Closed intentionally. This PR is withdrawn.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Stale ASR config The ASR step treats any existing Volcengine credential bundle as “ready”, but the onboarding flow only rewrites volcengine.resource_id when the user explicitly saves this form. Upgraded installs that already have APP ID and Access Token stored can therefore finish onboarding without ever updating the old volc.bigasr.sauc.duration value, which leaves Volcengine transcription broken until the user manually re-saves the credentials. const asrReady = Boolean(credentials?.volcengineConfigured || asrSaveState === 'saved'); const asrHasInput = Boolean(asrForm.appKey.trim() || asrForm.accessKey.trim()); const asrFormValid = Boolean(asrForm.appKey.trim() && asrForm.accessKey.trim()); Listener leak On Tauri, the microphone test registers the microphone:level listener before starting the native monitor. If startMicrophoneLevelMonitor() throws, the catch block only stops the monitor and never unregisters that listener, so the subscription can stay active and keep updating state until the user retries or leaves the page. if (isTauri) { const { listen } = await import('@tauri-apps/api/event'); const unlisten = await listen<{ level: number }>('microphone:level', event => { const level = Math.max(0, Math.min(1, event.payload.level ?? 0)); setMicLevel(level); if (level > 0.08) { setMicTestState('heard'); } }); micUnlistenRef.current = unlisten; await startMicrophoneLevelMonitor(prefs?.microphoneDeviceName ?? ''); } else { micMockTimerRef.current = window.setInterval(() => { const level = 0.2 + Math.random() * 0.5; setMicLevel(level); setMicTestState('heard'); }, 120); } } catch (error) { console.warn('[onboarding] microphone test failed', error); setMicMonitoring(false); setMicTestState('error'); setMicTestError(error instanceof Error ? error.message : String(error)); void stopMicrophoneLevelMonitor(); }