fix(windows): 缺失托盘图标时继续启动#72
Merged
appergb merged 1 commit intoApr 30, 2026
Merged
Conversation
Reviewer's GuideHandles missing default window icon more defensively so the Windows app can still start without a tray icon, instead of panicking during tray setup, and logs a startup warning when this happens. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- When skipping tray creation due to a missing default window icon, consider logging at a higher level (e.g.,
error!or including the expected asset path) so that misconfigured builds are more visible during diagnostics rather than just a warning in normal logs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- When skipping tray creation due to a missing default window icon, consider logging at a higher level (e.g., `error!` or including the expected asset path) so that misconfigured builds are more visible during diagnostics rather than just a warning in normal logs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
appergb
pushed a commit
that referenced
this pull request
Apr 30, 2026
包含本轮所有合并: - Codex 终审两条 HIGH (cancel race) 修复 (PR #79) - 6 个 Cooper-X-Oak/Codex bot PRs 自动合并 (#44 #49 #53 #68 #72 #73) - 2 个有冲突 PR 本地 rebase 后合并 (#66 cancel + 空转写并存 / #67 Windows docs) - README 破图修复 (PR #80) - workflow-scope 受限的 #48 + #75 由用户在 GitHub UI 直接合并 3 处版本字段同步:package.json + tauri.conf.json + Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
Fixes #无(不再新增 upstream issue)。
关联 fork 验证:Cooper-X-Oak#12。
本 PR 是从 fork/dev 已验证批次拆出的启动稳定性维护项:当 Tauri 默认窗口图标缺失时,不再
unwrap()直接让应用启动失败,而是记录 warning 并跳过托盘图标创建。修复 / 新增 / 改进
app.default_window_icon().unwrap()改为if let Some(icon)分支。[startup] default window icon missing; tray icon disabled。兼容
测试计划
git diff --check -- openless-all/app/src-tauri/src/lib.rscargo check --manifest-path openless-all/app/src-tauri/Cargo.tomlkernel32.lib缺失;不是本次代码改动触发。完整编译以 GitHub Windows Tauri checks 为准。Summary by Sourcery
Bug Fixes: