Skip to content

fix: stabilize Windows recording startup#94

Merged
appergb merged 2 commits into
mainfrom
codex/windows-recording-fixes
Apr 30, 2026
Merged

fix: stabilize Windows recording startup#94
appergb merged 2 commits into
mainfrom
codex/windows-recording-fixes

Conversation

@appergb
Copy link
Copy Markdown
Collaborator

@appergb appergb commented Apr 30, 2026

Summary

  • remove the Windows blur/visibility synthetic keyup fallback that was causing hold-to-talk flicker
  • start the recorder without the duplicate microphone preflight so audio capture begins as early as possible
  • replace Windows shell/reg subprocess calls with native APIs to avoid console window flashes
  • tighten the hold-mode regression test and carry the branch on top of origin/main, including PR fix(insertion): 修正 macOS 无权限时插入状态 #92

Verification

  • npm run build
  • npx tsc --noEmit
  • cargo test
  • cargo fmt --check
  • git diff --check
  • npm audit --audit-level=high (no high/critical; existing moderate vite/esbuild advisory remains)

Notes

  • The branch was updated onto the latest origin/main before verification; the only upstream delta was PR fix(insertion): 修正 macOS 无权限时插入状态 #92 in insertion.rs and it does not overlap with these files.
  • Windows target cross-check from this mac host is still blocked by the local toolchain missing the target C headers required by ring (assert.h not found).

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @appergb, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@appergb
Copy link
Copy Markdown
Collaborator Author

appergb commented Apr 30, 2026

@codex

@chatgpt-codex-connector
Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@appergb appergb merged commit 884455a into main Apr 30, 2026
2 checks passed
@appergb appergb deleted the codex/windows-recording-fixes branch April 30, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant