refactor: Extract MSColab dialogs to separate modules#2993
refactor: Extract MSColab dialogs to separate modules#2993Sumit6307 wants to merge 2 commits intoOpen-MSS:developfrom
Conversation
|
Hi @ReimarBauer , please have a look at this PR. Thanks! |
|
|
||
| This file is part of MSS. | ||
|
|
||
| :copyright: Copyright 2019-2024 by the MSS team, see AUTHORS. |
There was a problem hiding this comment.
please adjust the year to -2026
mslib/msui/mscolab_connect_dialog.py
Outdated
|
|
||
| This file is part of MSS. | ||
|
|
||
| :copyright: Copyright 2019-2024 by the MSS team, see AUTHORS. |
There was a problem hiding this comment.
please adjust the year to -2026
|
We usually describe a task or project within an issue in our project, and then discuss it there. Once it's been assigned, we start working on it. I noticed you were interested in Google Summer of Code (GSoC). We won’t be taking part this year. |
Hi @ReimarBauer, Thanks a lot for the review and feedback! I’ve updated the copyright year to 2019–2026 in both files and fixed the linting issues reported by the CI. I understand the preferred workflow of discussing tasks in an issue before starting work. Thanks for pointing that out — I’ll follow this process for future contributions. Noted about GSoC as well, thanks for the clarification. I’m happy to continue contributing to MSS regardless and align with the project’s contribution guidelines. Please let me know if any further changes are needed. |
Purpose of PR?:
This PR refactors mslib/msui/mscolab.py to address the "God Class" maintainability issue. It extracts the MSColab_ConnectDialog and MSColab_OperationArchiveBrowser classes into their own dedicated modules (mslib/msui/mscolab_connect_dialog.py and mslib/msui/mscolab_archive_browser.py). This separation significantly reduces the size of mscolab.py and improves code organization without changing functionality.
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
python -m py_compile.Additional information for reviewer? :
This is part of a larger effort to improve the modularity of the MSColab client. By isolating UI components, we pave the way for better testability and future separation of network logic.
Does this PR results in some Documentation changes?
No
Checklist:
<type>: <subject>