-
Notifications
You must be signed in to change notification settings - Fork 33
Introducing Function system #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/modules/linear_boltzmann_solvers/dsa/acceleration_diffusion_cfem.cc
Show resolved
Hide resolved
zhardy-lanl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Quite a few repetitive comments.
- I think we should discuss the
ResponseFunctionclasses. I think we should use a more general name. There can be many different scenarios where a group-wise function of position and material ID are used that are not response evaluations. It would naturally fit within aSpatialMaterialFunctionand could be combined withScalarSpatialMaterialFunctionby changing the argument ordering and usingnum_components=1default. - I am still quite confused about the
valargument ofScalarMaterialFunction
modules/linear_boltzmann_solvers/a_lbs_solver/acceleration/diffusion_mip_solver.cc
Outdated
Show resolved
Hide resolved
modules/linear_boltzmann_solvers/a_lbs_solver/acceleration/diffusion_mip_solver.cc
Outdated
Show resolved
Hide resolved
8ab0254 to
b16c92b
Compare
test/modules/linear_boltzmann_solvers/dsa/acceleration_diffusion_cfem.cc
Show resolved
Hide resolved
Do you want to solve this in this PR (i.e. I need to do more work here) or in a new issue/PR? The main difference between I am just making sure if this PR is ready... |
zhardy-lanl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #68 for the response function discussion. This is good with me.
|
IDK what happened for the first time, but the regression test workflow took 63 minutes and did not finish. I re-run it and it finished in an expected time. 🤔 |
Unless anything needs to be done with respect to that, feel free to merge this. |
wdhawkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Clean, straightforward, easy to understand. I'm not overly opposed to the ResponseFunction naming. I can understand the argument for changing it. Maybe EvalFunction or something. I don't think I have strong opinions either way.
b16c92b to
4171a6d
Compare
This introduces the Function system with following ideas:
CallLua???Functionet al.Functions are stored in their dedicatedfunction_stack.std::shared_ptrto an appropriateFunctionvia a C++ API.Refs #9