Skip to content

Conversation

@Jordonbc
Copy link
Contributor

@Jordonbc Jordonbc commented Jan 8, 2026

No description provided.

@Jordonbc Jordonbc merged commit fa2879f into Stable Jan 8, 2026
4 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9e0d64100

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 33 to +37
# The VCS trait and VCS-related error type.
vcs = ["dep:thiserror"]
vcs = ["dep:thiserror", "backend-registry"]

# Static + dynamic backend registry (linkme + logging).
backend-registry = ["vcs", "dep:linkme", "dep:log"]
# Backend discovery via the `BACKENDS` registry (link-time registration).
backend-registry = ["dep:linkme"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Make backend-registry imply vcs again

backend_descriptor.rs imports crate::{Result, Vcs}, which are only defined under feature = "vcs" (see src/lib.rs). After this change, backend-registry no longer enables vcs, so cargo build --no-default-features --features backend-registry will now fail with unresolved imports. This is a regression from the previous feature graph. Consider restoring vcs as a dependency of backend-registry or gating backend_descriptor behind both features.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants