Skip to content

Conversation

@Xen0Xys
Copy link
Member

@Xen0Xys Xen0Xys commented Jun 12, 2025

No description provided.

@Xen0Xys Xen0Xys requested a review from Copilot June 12, 2025 09:23
@Xen0Xys Xen0Xys self-assigned this Jun 12, 2025
@Xen0Xys Xen0Xys added the enhancement New feature or request label Jun 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the Admin and User functionality while updating and fixing related endpoints and services. Key changes include adjusting caching durations in image endpoints, adding new admin user management endpoints, and updating user-related endpoints and service methods (including user creation, password changes, and avatar updates).

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/modules/webtoon/image/image.controller.ts Updated caching duration and refined image retrieval logic.
src/modules/webtoon/admin/admin.module.ts Added UsersModule dependency and registered AdminUsersController.
src/modules/webtoon/admin/admin.controller.ts Injected UsersService for potential additional admin logic.
src/modules/webtoon/admin/admin-users.controller.ts Introduced new endpoints for admin user management.
src/modules/users/users.service.ts Added createUser, changePassword, changeUserPassword, getUsers, and deleteUserById functions.
src/modules/users/users.module.ts Exported UsersService for broader usage.
src/modules/users/users.controller.ts Changed avatar update endpoint to PATCH and added a new password update endpoint.
src/modules/users/models/dto/create-user.dto.ts Added DTO for user creation with validations.
src/modules/users/models/dto/change-password.dto.ts Added DTO for password change with validations.
src/modules/storage/storage.service.ts Updated S3 client branch to write file with specified storage class.
package.json Updated dependency versions.
Comments suppressed due to low confidence (1)

src/modules/users/users.controller.ts:38

  • The change from POST to PATCH for the avatar update endpoint is semantically appropriate for updating resources; please ensure that the API documentation is updated to reflect this change.
@Patch("avatar/:sum")

Xen0Xys and others added 6 commits June 12, 2025 11:24
@Xen0Xys Xen0Xys merged commit a5c4d40 into main Jun 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants