🐛 Merge Staging to Main #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges changes from the staging branch to main, introducing retry logic and timeout handling for HTTP requests to improve resilience against network failures. The changes address stability issues when fetching webtoon data and downloading images.
Key Changes:
- Added retry logic with exponential backoff for failed HTTP requests across multiple services
- Implemented a hard timeout mechanism for axios requests to prevent indefinite hanging
- Updated DOM selectors in webtoon providers to match current website structure
- Updated several dependencies including fastify, @types/node, and TypeScript tooling
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/webtoon/webtoon/webtoon-downloader.service.ts | Added retry logic for image downloads with error handling |
| src/modules/webtoon/webtoon/providers/webtoon.provider.ts | Implemented retry loops for genre fetching, updated DOM selectors, and added hard timeouts to all HTTP requests |
| src/modules/webtoon/webtoon/providers/webtoon-canvas.provider.ts | Added hard timeouts to HTTP requests and improved page count detection logic |
| src/modules/webtoon/webtoon/download-manager.service.ts | Added retry mechanism for episode downloads |
| src/modules/misc/misc.service.ts | Introduced axiosWithHardTimeout utility function and applied it to image downloads |
| package.json | Updated dependency versions for fastify, @types/bun, @types/node, and @typescript-eslint/parser |
| bun.lock | Updated lockfile to reflect dependency changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/modules/webtoon/webtoon/providers/webtoon-canvas.provider.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.