Skip to content

chore(ci): remove CircleCI configuration file#199

Merged
guillaumejparis merged 1 commit into
mainfrom
chore/remove_circle
Jun 25, 2026
Merged

chore(ci): remove CircleCI configuration file#199
guillaumejparis merged 1 commit into
mainfrom
chore/remove_circle

Conversation

@guillaumejparis

Copy link
Copy Markdown
Member

Proposed changes

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Copilot AI review requested due to automatic review settings June 25, 2026 09:30
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jun 25, 2026
@Filigran-Automation

Copy link
Copy Markdown
Contributor

🤖 [AI-generated]

Hey @guillaumejparis! 👋 Thanks a lot for opening PR #199 — removing the old CircleCI config is great housekeeping, really appreciate it! 🙏

I just had a quick look and I think the description could be enhanced a little to help reviewers get through it faster. I haven't changed anything in your description — just a gentle, optional suggestion:

Area What could help Suggestion
Proposed changes The section still has the empty template bullets A line or two on what's being removed and why (e.g. CircleCI is no longer used now that CI runs on GitHub Actions)
Related issues Closes #ISSUE-NUMBER is still the placeholder Link the tracking issue (Closes #<n>) — every PR is expected to be linked to an issue
Testing Instructions Still the placeholder steps A quick note on how to verify (e.g. confirm GitHub Actions still runs green and nothing depends on .circleci/config.yml)

💡 If helpful, the contribution conventions / PR template walk through what to include.

No rush at all — thanks again for contributing to the project! 🚀

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy CircleCI configuration from the repository, presumably as part of retiring CircleCI usage in favor of another CI system (GitHub Actions workflows already exist in .github/workflows/).

Changes:

  • Deleted .circleci/config.yml, removing all CircleCI jobs and workflows (multi-OS build/test/packaging logic previously defined there).
Comments suppressed due to low confidence (1)

.circleci/config.yml:1

  • Deleting the CircleCI config removes the only in-repo automation I can find that builds release installers and uploads binaries/scripts to JFrog Artifactory (the push to jfrog steps). The existing GitHub Actions workflow (.github/workflows/agent-ci.yml) builds and uploads run artifacts, but does not publish to JFrog (and there are no other JFROG/artifactory references in the repo). If JFrog publishing is still required for releases, this PR should also add the equivalent publishing workflow (or document where publishing has moved) to avoid breaking the release/distribution pipeline.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@laugiov laugiov self-assigned this Jun 25, 2026
@guillaumejparis guillaumejparis merged commit 547d443 into main Jun 25, 2026
23 of 25 checks passed
@guillaumejparis guillaumejparis deleted the chore/remove_circle branch June 25, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants