Skip to content

Conversation

antoinemzs
Copy link
Member

Proposed changes

  • A small overlook fixed: use the string value of the enum instead of the enum item itself when creating the "struct for comparison"

Changes from:

{
    "type": "MatchTypes.MATCH_TYPE_FUZZY",
}

to:

{
    "type": "fuzzy",
}

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
@antoinemzs antoinemzs changed the title [client] enum value as "type" in make_struct... [client] enum value as "type" in make_struct_for_matching Dec 6, 2024
@antoinemzs antoinemzs merged commit 0a090fe into release/1.10.0 Dec 6, 2024
3 checks passed
@antoinemzs antoinemzs deleted the fix/use_enum_value_for_sig_type branch December 6, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants