Skip to content

[client] enum value as "type" in make_struct_for_matching #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

[client] enum value as "type" in make_struct_for_matching #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyobas/signatures/signature_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def __init__(
# }
def make_struct_for_matching(self, data):
struct = {
"type": self.match_policy.match_type,
"type": self.match_policy.match_type.value,
"data": data,
}

Expand Down
6 changes: 3 additions & 3 deletions test/signatures/test_signature_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def test_make_struct_create_expected_struct_for_simple_sig_type(self):
data = "just a simple string"
simple_struct = simple_signature_type.make_struct_for_matching(data=data)

self.assertEqual(simple_struct.get("type"), MatchTypes.MATCH_TYPE_SIMPLE)
self.assertEqual(simple_struct.get("type"), MatchTypes.MATCH_TYPE_SIMPLE.value)
self.assertEqual(simple_struct.get("data"), data)
self.assertFalse("score" in simple_struct.keys())

Expand All @@ -30,7 +30,7 @@ def test_make_struct_create_expected_struct_for_fuzzy_sig_type(self):
data = "just another simple string"
simple_struct = fuzzy_signature_type.make_struct_for_matching(data=data)

self.assertEqual(simple_struct.get("type"), MatchTypes.MATCH_TYPE_FUZZY)
self.assertEqual(simple_struct.get("type"), MatchTypes.MATCH_TYPE_FUZZY.value)
self.assertEqual(simple_struct.get("data"), data)
self.assertEqual(simple_struct.get("score"), fuzzy_signature_type_score)

Expand All @@ -48,7 +48,7 @@ def test_make_struct_create_expected_struct_for_fuzzy_sig_type_when_score_is_0(
data = "just another simple string"
simple_struct = fuzzy_signature_type.make_struct_for_matching(data=data)

self.assertEqual(simple_struct.get("type"), MatchTypes.MATCH_TYPE_FUZZY)
self.assertEqual(simple_struct.get("type"), MatchTypes.MATCH_TYPE_FUZZY.value)
self.assertEqual(simple_struct.get("data"), data)
self.assertEqual(simple_struct.get("score"), fuzzy_signature_type_score)

Expand Down