Conversation
antoinemzs
reviewed
Jun 3, 2026
Member
antoinemzs
left a comment
antoinemzs
left a comment
There was a problem hiding this comment.
I understand we support mutually exclusive subsets of config keys for one or the other use cases
May I suggest we document the superset of config keys the normal way, and then provide use-case specific examples of working configs?
Comment on lines
+126
to
+127
| | engine.username | ENGINE_USERNAME | | This parameter is optional. Login for the database | | ||
| | engine.password | ENGINE_PASSWORD | | This parameter is optional. Password for the database | |
Member
There was a problem hiding this comment.
If optional then why setting them?
Comment on lines
116
to
+117
| | engine.username | ENGINE_USERNAME | | This parameter is optional. Login for the database | | ||
| | engine.password | ENGINE_PASSWORD | | This parameter is optional. Password for the database | | ||
| | engine.password | ENGINE_PASSWORD | | This parameter is optional. Password for the database | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.