[backend] refactor(contract-types): extract ContractOutputType business logic into handler classes (#4302)#4960
Merged
savacano28 merged 1 commit intomasterfrom Feb 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4960 +/- ##
============================================
+ Coverage 56.03% 56.23% +0.20%
- Complexity 4441 4492 +51
============================================
Files 986 997 +11
Lines 29261 29357 +96
Branches 2142 2147 +5
============================================
+ Hits 16396 16510 +114
+ Misses 11920 11896 -24
- Partials 945 951 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4826ef8 to
9545f82
Compare
heditar
reviewed
Feb 18, 2026
5e4cc4e to
80ab146
Compare
b6d7d39 to
adc775e
Compare
adc775e to
eec83d3
Compare
Contributor
|
Tested all output handlers |
heditar
approved these changes
Feb 25, 2026
eec83d3 to
fffbd18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Chunk 1: Part 1
Testing Instructions
Test refact_2026-02-18T08_40_12.089231500Z_(with_teams & with_players & with_variable_values).zip
Atomic Testing with Payload and Output Parsers
You should be able to execute an atomic test using a payload with output parsers configured.
The test should work as expected, with normal execution behavior.
Inject Execution with Nuclei
You should be able to execute an inject operation Nuclei.
The execution should complete successfully and produce:
You should be able to execute an atomic test with a defined vulnerability expectation.
If the payload uses an output parser of type cve, the system should correctly validate the vulnerability expectation against the detected CVE.
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...