Add error handling for DNS resolution in getK8sRemoteURLArrayFunc#1712
Merged
Add error handling for DNS resolution in getK8sRemoteURLArrayFunc#1712
Conversation
Merged
…RLArrayFunc Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on pull request #1708 for T8 changes
Add error handling for DNS resolution in getK8sRemoteURLArrayFunc
Feb 23, 2026
nmaguiar
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ow.net.getDNSingetK8sRemoteURLArrayFunchad no error handling, causing the peer function to throw on DNS lookup failures or network issues instead of degrading gracefully.Changes
js/owrap.ch.js: Wrapow.net.getDNScall in atry-catch; on failure, log the error vialogErr(including the DNS name for context) and return[]Consistent with the existing
try-catchalready used forow.net.getHostAddress()in the same function.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.