-
Notifications
You must be signed in to change notification settings - Fork 194
Build machineless libmetal v2025.10 #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build machineless libmetal v2025.10 #354
Conversation
libmetal can be build without any machine support. It is possible that vendors implement machine specific interfaces outside of libmetal and link it with demos during build time. Hence, remove requirement to have MACHINE and PROJECT_MACHINE variables from the build system. If vendor prefer to choose 'template' machine, they can pass such option during cmake configuration. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
This directory was removed and re-inroduced by mistake, and should not exists in the libmetal. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
Declare sys_irq_enable() and sys_irq_enable() directly in lib/system/@PROJECT_SYSTEM@/sys.h. This allows to declare the machine out of tree of the libmetal but also to support the in-tree template. [minor style related fix by tanmay] Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
796911b to
243877d
Compare
|
@arnopo Hi just checking in - will this be merged soon? As we have a few openamp-sys-ref PRs dependent on this :) |
I understood from @tnmysh that this was only needed to ensure compatibility with the openamp-system-reference v2025.10, as specified here: Do you mean that you also need a v2025.10.1 release for the openamp-system-reference repository? Regarding this PR: Alternatively, libmetal PR #350, which is the mirror for the main branch, should allow you to move forward on the openamp-system-reference |
edmooring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go.
|
I plan to perform few non regression tests on this one before merging and add the v2025.10.1 tag, i target this for beginning of next week |
libmetal doesn't need MACHINE variable to be defined. Without MACHINE defined, it relies on external vendor extension for machine related interface implementation and link with demos during build time.