Skip to content

Conversation

@tnmysh
Copy link
Collaborator

@tnmysh tnmysh commented Dec 24, 2025

libmetal doesn't need MACHINE variable to be defined. Without MACHINE defined, it relies on external vendor extension for machine related interface implementation and link with demos during build time.

libmetal can be build without any machine support. It is possible that
vendors implement machine specific interfaces outside of libmetal and
link it with demos during build time. Hence, remove requirement to have
MACHINE and PROJECT_MACHINE variables from the build system. If vendor
prefer to choose 'template' machine, they can pass such option during
cmake configuration.

Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
This directory was removed and re-inroduced by mistake, and should
not exists in the libmetal.

Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
Declare sys_irq_enable() and sys_irq_enable() directly in
lib/system/@PROJECT_SYSTEM@/sys.h.
This allows to declare the machine out of tree of the libmetal but
also to support the in-tree template.

[minor style related fix by tanmay]

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
@tnmysh tnmysh force-pushed the build_machineless_libmetal_v2025.10 branch from 796911b to 243877d Compare December 24, 2025 16:23
@bentheredonethat
Copy link
Contributor

@arnopo Hi just checking in - will this be merged soon? As we have a few openamp-sys-ref PRs dependent on this :)

@arnopo
Copy link
Contributor

arnopo commented Jan 7, 2026

@arnopo Hi just checking in - will this be merged soon? As we have a few openamp-sys-ref PRs dependent on this :)

I understood from @tnmysh that this was only needed to ensure compatibility with the openamp-system-reference v2025.10, as specified here:
https://github.com/OpenAMP/openamp-system-reference/releases/tag/v2025.10.0

Do you mean that you also need a v2025.10.1 release for the openamp-system-reference repository?

Regarding this PR:
Since it will be associated with a new release tag v2025.10.1, it needs to be approved first by @edmooring. After that, I will merge it and perform some non-regression tests before creating the new release tag. So, this may take some time.

Alternatively, libmetal PR #350, which is the mirror for the main branch, should allow you to move forward on the openamp-system-reference main branch.

Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@arnopo
Copy link
Contributor

arnopo commented Jan 13, 2026

I plan to perform few non regression tests on this one before merging and add the v2025.10.1 tag, i target this for beginning of next week

@arnopo arnopo merged commit f281301 into OpenAMP:v2025.10 Jan 19, 2026
1 check passed
@arnopo arnopo added this to the Release V2025.10 milestone Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants