Changes from review of Pull request #37#40
Merged
arnopo merged 13 commits intoOpenAMP:main-nextfrom Mar 5, 2025
Merged
Conversation
- restructure the lists - update the list of supported RTOS Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
This patch updates the documentation to consistently use the correct capitalization for 'RPMsg' instead of 'RPmsg'. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
OpenAMP case corrections requested in pull request 37 review
punctuation corrections requested in pull request 37 review
Grammatical corrections requested in pull request 37 review
corrections requested in pull request 37 review
corrections requested in pull request 37 review
corrections requested in pull request 37 review
the inter processor 'demo' page is providing 'reference implementation' of demos running as processes on linx.
review request. Refer issue 38 OpenAMP#38
requested swap of order during documentation meeting
wrong demo script given in reference to docker images
Review feedback In the picture, for the rpmsg_char driver should be "from ept 0x402" not 0x001. Correct typo in rpms_ping
arnopo
approved these changes
Jan 23, 2025
danmilea
suggested changes
Jan 27, 2025
Collaborator
danmilea
left a comment
danmilea
left a comment
There was a problem hiding this comment.
Other than one minor subject-predicate agreement comment, it looks good to merge.
| ~~~~~~~~~~~~~~ | ||
|
|
||
| RPMsg endpoints provide logical connections on top of RPMsg channel. It allows the user to bind multiple rx callbacks on the same channel. | ||
| RPMsg endpoints provide logical connections on top of an RPMsg channel. They allows the user to bind multiple rx callbacks on the same channel. |
Collaborator
There was a problem hiding this comment.
s/They allows/They allow/
Author
There was a problem hiding this comment.
Made this change on top of pull request 41.
28 tasks
This was referenced Mar 5, 2025
Merged
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to capture items from pull request #37 as well as a couple of minor errors noticed during updates.
These items are not in issue 38 (#38)