Skip to content

chore(fix): fix proxy agent#1206

Merged
wing328 merged 17 commits into
masterfrom
proxy-agent-fix
May 20, 2026
Merged

chore(fix): fix proxy agent#1206
wing328 merged 17 commits into
masterfrom
proxy-agent-fix

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented May 19, 2026

Summary by cubic

Fixes proxy handling in the generator CLI so HTTP(S) requests honor HTTP_PROXY/HTTPS_PROXY. Adds a proxy-agent type shim and Jest config updates; temporarily disables the HTTP proxy check in CI.

  • Bug Fixes

    • Import named ProxyAgent from proxy-agent; reuse a single instance for httpAgent/httpsAgent.
    • Set proxy = false in @nestjs/axios when proxy envs are present.
    • Add apps/generator-cli/src/proxy-agent.d.ts to support both default and named imports.
    • Jest: broaden transform to ^.+\\.[cm]?[tj]s$, include mjs/cjs, and allowlist proxy-agent deps in transformIgnorePatterns.
  • CI

    • Comment out the "Test with HTTP proxy" step in .github/workflows/build.yml.

Written for commit 28f5509. Summary will update on new commits. Review in cubic

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread apps/generator-cli/src/app/app.module.ts Outdated
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread .github/workflows/build.yml Outdated
@cubic-dev-ai
Copy link
Copy Markdown
Contributor

cubic-dev-ai Bot commented May 20, 2026

You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment @cubic-dev-ai review.

@wing328 wing328 added the bug Something isn't working label May 20, 2026
@wing328 wing328 merged commit 86b776e into master May 20, 2026
6 checks passed
@wing328 wing328 deleted the proxy-agent-fix branch May 20, 2026 09:33
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 2.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant