config.schema.json: enhance required generator fields.#492
Merged
kay-schecker merged 3 commits intoOpenAPITools:masterfrom Apr 15, 2022
Merged
config.schema.json: enhance required generator fields.#492kay-schecker merged 3 commits intoOpenAPITools:masterfrom
kay-schecker merged 3 commits intoOpenAPITools:masterfrom
Conversation
Contributor
Author
|
Related to #457. |
|
Wondering what the status of this. Seems to have stalled but not sure why? |
pagyew
approved these changes
Jan 21, 2022
kay-schecker
approved these changes
Apr 15, 2022
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the required generator fields in
config.schema.json.Prior to this change, the schema required the definition of a
globpattern in theglobfield of theopenapitools.json.Since the glob pattern only matches local files, it's not possible to provide an URL pointing to the API definition in this field.
An URL has to be defined in the
inputSpecfield instead.With this change the schema requires either a
globor aninputSpec, which corresponds to the current implementation.