fix(config): VSCode workspace $schema resolultion#515
Merged
kay-schecker merged 2 commits intoOpenAPITools:masterfrom Mar 17, 2022
Merged
fix(config): VSCode workspace $schema resolultion#515kay-schecker merged 2 commits intoOpenAPITools:masterfrom
kay-schecker merged 2 commits intoOpenAPITools:masterfrom
Conversation
- VSCode workspaces resolve 'somepath' as relative to root - this causes "ENOENT" - specifying path as explicitly relative fixes this issue
Contributor
Author
|
Happy to add tests or anything else to make this more robust. This could also warrant an upstream bug report, but I probably won't have time to put that together. |
kay-schecker
approved these changes
Mar 17, 2022
kay-schecker
approved these changes
Mar 17, 2022
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in VSCode workspace context the
$schemareference to the.jsoninnode_modulesis not resolving. Seems that the path (which is usually a web-accessible URL) is resolved as relative to/root (see screenshot). This causesENOENTand prevents grammars from loading.Specifying path as explicitly relative fixes this issue.