[php] Fix PHP generator validation for nullable required properties#22292
Merged
wing328 merged 2 commits intoNov 8, 2025
Merged
Conversation
achton
changed the title
wing328
reviewed
Nov 6, 2025
… models. Also fix PHP annotations related to same.
achton
force-pushed
the
fix-issue-21497-php-null-nullable
branch
from
ec75a1d to
5e2e7e5
Compare
wing328
reviewed
Nov 7, 2025
| * Sets {{name}} | ||
| * | ||
| * @param {{{dataType}}}{{^required}}|null{{/required}} ${{name}}{{#description}} {{{.}}}{{/description}}{{^description}} {{{name}}}{{/description}} | ||
| * @param {{{dataType}}}{{#isNullable}}|null{{/isNullable}} ${{name}}{{#description}} {{{.}}}{{/description}}{{^description}} {{{name}}}{{/description}} |
Member
There was a problem hiding this comment.
can we also apply the same update here to handle both required and optional properties?
wing328
reviewed
Nov 7, 2025
| {{#vars}} | ||
| {{#required}} | ||
| if ($this->container['{{name}}'] === null) { | ||
| if ($this->container['{{name}}'] === null{{#isNullable}} && !$this->isNullableSetToNull('{{name}}'){{/isNullable}}) { |
Member
There was a problem hiding this comment.
can we also apply the same update here to handle both required and optional properties?
Member
|
I'll address those comments with a separate PR UPDATE: merged #22307 |
Member
|
FYI. Merged another PR (#22310) to refactor the template a bit |
6 tasks
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…penAPITools#22292) * [php] Fix null+required properties to accept null values in generated models. Also fix PHP annotations related to same. * [php] Update samples.
FreekVR
added a commit
to myparcelnl/sdk
that referenced
this pull request
Jul 8, 2026
…re not allowing a `null` value applies an upstream patch to our custom model mustache template. fixes "[name] can't be null" errors when setting a required value to `null` if a null value was allowed (eg presence is required, but can be empty) see OpenAPITools/openapi-generator#22292
FreekVR
added a commit
to myparcelnl/sdk
that referenced
this pull request
Jul 8, 2026
Completes the OpenAPITools/openapi-generator#22292 backport started in 3e9953a. That commit fixed listInvalidProperties() but left the generated getter/setter PHPDoc showing e.g. `@return int` for required+nullable properties like RefTypesMoneyNullableAmount::amount, which can legitimately be null. Append the |null that the upstream fix adds for these properties and regenerate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MyParcelBot
pushed a commit
to myparcelnl/sdk
that referenced
this pull request
Jul 9, 2026
## [11.0.0-beta.29](v11.0.0-beta.28...v11.0.0-beta.29) (2026-07-09) ### ⚠ BREAKING CHANGES * **openapi:** loosen and apply consistent validation for enum values, fix required nullables (#623) ### ✨ New Features * **openapi:** loosen and apply consistent validation for enum values, fix required nullables ([#623](#623)) ([2164721](2164721)), closes [OpenAPITools/openapi-generator#22292](OpenAPITools/openapi-generator#22292) [OpenAPITools/openapi-generator#22292](OpenAPITools/openapi-generator#22292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHP generator bug where nullable-but-required model properties were always flagged as invalid when set to null. Update validation/docblocks so explicit null assignments are honored. Closes #21497.
@jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)