[BUG] [Java] Escaped bean property name should be resumed

[yue9944882]

Description

xref: kubernetes-client/java#595

in the kubernetes openapi spec, there's some escaped property name in the schema:

    "io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1beta1.JSONSchemaProps": {
      "description": "JSONSchemaProps is a JSON-Schema following Specification Draft 4 (http://json-schema.org/).",
      "properties": {
        "$ref": {
          "type": "string"
        },
        "$schema": {
          "type": "string"
        }
....

the generator doesn't seem to properly handle the name and my java output is failing the compiliation:

@ApiModel(description = "JSONSchemaProps is a JSON-Schema following Specification Draft 4 (http://json-schema.org/).")
@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2019-06-20T12:55:05.588Z[Etc/UTC]")
public class V1beta1JSONSchemaProps {
  public static final String SERIALIZED_NAME_$_REF = "$ref";
  @SerializedName(SERIALIZED_NAME_$_REF)
  private String $ref;

  public static final String SERIALIZED_NAME_$_SCHEMA = "$schema";
  @SerializedName(SERIALIZED_NAME_$_SCHEMA)
  private String $schema;

openapi-generator version

v4.0.0

OpenAPI declaration file content or url

Command line used for generation

Steps to reproduce

Related issues/PRs

Suggest a fix

it seems that in the swagger-codegen we won't have the issue.

https://github.com/kubernetes-client/java/blob/dc82549dde1eeea7593203dec788af0fe33685a7/kubernetes/src/main/java/io/kubernetes/client/models/V1beta1JSONSchemaProps.java#L38-L42

[yue9944882]

anything i can do to move this forward? it's critical for migrating kubernetes client from swagger-gen to openapi-gen..

[davidxia]

@yue9944882 do you have repro steps for this?

[yue9944882]

yes, try patch kubernetes-client/gen#117 locally and you'll hit this.

[wing328]

@yue9944882 Tried to repeat the issue with a leading dollar sign in the property name as follows:

 public class OuterComposite {
-  public static final String SERIALIZED_NAME_MY_NUMBER = "my_number";
-  @SerializedName(SERIALIZED_NAME_MY_NUMBER)
-  private BigDecimal myNumber;
+  public static final String SERIALIZED_NAME_$_MY_NUMBER = "$my_number";
+  @SerializedName(SERIALIZED_NAME_$_MY_NUMBER)
+  private BigDecimal $myNumber;

but the Java code is compiling fine:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 43.644 s
[INFO] Finished at: 2019-08-15T22:58:54+08:00
[INFO] ------------------------------------------------------------------------

so am I repeating or understanding the issue correctly?

[wing328]

the generator doesn't seem to properly handle the name and my java output is failing the compiliation:

Can you share the compilation error with us? The dollar sign may not be the culprit.

[fabiokung]

the compilation error was caused by something else, with the Builder generated by sundr.io:

sundrio/sundrio#156