Skip to content

Conversation

@MartinDelille
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @muttleyxd

@wing328
Copy link
Member

wing328 commented Sep 14, 2021

Tests passed via https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/237580695

Trigger a build failure via https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/237581230, which failed as expected.

Thanks for the quick fix.

@wing328 wing328 merged commit dd6e399 into OpenAPITools:master Sep 14, 2021
@wing328 wing328 added this to the 5.3.0 milestone Sep 14, 2021
@MartinDelille
Copy link
Contributor Author

This would be great if the test were run on the affected sample! But I imagine this would require some CI configuration work!

@wing328
Copy link
Member

wing328 commented Sep 14, 2021

Definitely. The Travis CI runs out of free credits so we'll try to move the tests (c++ qt petstore samples) to CircleCI instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants