Skip to content

Conversation

@PiDelport
Copy link
Contributor

@PiDelport PiDelport commented Sep 18, 2021

The Rust reqwest client's form handling fails to call to_string on array params, which fails to compile for arrays of values other than String.

This adds the missing to_string calls (similar to what's done with queryParams earlier in the function).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05)

@PiDelport PiDelport force-pushed the fix-rust-client-form-array-params-to-string branch from 68f09ca to f0f9a46 Compare September 20, 2021 08:24
@PiDelport
Copy link
Contributor Author

(Rebased)

@wing328
Copy link
Member

wing328 commented Sep 21, 2021

LGTM but I've not tested it locallly.

@wing328 wing328 merged commit ce30a3f into OpenAPITools:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants