Skip to content

fix: #9976 do not escape already escaped string in examples#10613

Open
benfonty wants to merge 1 commit intoOpenAPITools:masterfrom
benfonty:fix-9976-escaped-quotes-in-example
Open

fix: #9976 do not escape already escaped string in examples#10613
benfonty wants to merge 1 commit intoOpenAPITools:masterfrom
benfonty:fix-9976-escaped-quotes-in-example

Conversation

@benfonty
Copy link
Contributor

replaced the escapeDoubleQuote lambda so that already escaped double quotes in examples are not escaped again.

cc @nmuesch

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@benfonty benfonty force-pushed the fix-9976-escaped-quotes-in-example branch from 0d5ed1c to 12d68d2 Compare December 8, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant