Skip to content

[Java][Spring] Fix #13365 Adjusted pojo.mustache to handle required fields when beanValidation false#13580

Merged
wing328 merged 5 commits into
OpenAPITools:masterfrom
DeaneOC:Required-not-applied-to-fields-spring
Oct 7, 2022
Merged

[Java][Spring] Fix #13365 Adjusted pojo.mustache to handle required fields when beanValidation false#13580
wing328 merged 5 commits into
OpenAPITools:masterfrom
DeaneOC:Required-not-applied-to-fields-spring

Conversation

@DeaneOC
Copy link
Copy Markdown
Contributor

@DeaneOC DeaneOC commented Oct 3, 2022

When a field was marked as required and beanValidation was false the @NotNull field was missing. The pojo.mustache has been updated to include this. This resolves #13365 and #13196

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
  • [x]
    @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09)

Contributed on behalf of the @opencastsoftware open source team. 👋

Comment thread modules/openapi-generator/src/test/resources/bugs/issue_13365_2.yml Outdated
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 6, 2022

@DeaneOC can you please resolve the merge conflicts when you've time?

…rator into Required-not-applied-to-fields-spring

# Conflicts:
#	modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
@DeaneOC
Copy link
Copy Markdown
Contributor Author

DeaneOC commented Oct 7, 2022

@wing328 Conflicts resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][JAVA][SPRING] Required in body fields not being applied

4 participants