Skip to content

Remove beta in faraday library support (ruby client)#13823

Merged
wing328 merged 1 commit intomasterfrom
ruby-remove-beta
Oct 26, 2022
Merged

Remove beta in faraday library support (ruby client)#13823
wing328 merged 1 commit intomasterfrom
ruby-remove-beta

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Oct 26, 2022

take faraday library support out of beta as it's been added a while ago and lots of PRs have been merged to improve it.

to close #13811

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@wing328 wing328 added this to the 6.2.1 milestone Oct 26, 2022
@wing328 wing328 merged commit a66874f into master Oct 26, 2022
@wing328 wing328 deleted the ruby-remove-beta branch October 26, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ruby] Question about Faraday support

1 participant