Skip to content

fixes #10836, Adding vendor extension: x-go-srctype-tag#13900

Open
JasonTashtego wants to merge 1 commit into
OpenAPITools:masterfrom
JasonTashtego:fix-issue-10836
Open

fixes #10836, Adding vendor extension: x-go-srctype-tag#13900
JasonTashtego wants to merge 1 commit into
OpenAPITools:masterfrom
JasonTashtego:fix-issue-10836

Conversation

@JasonTashtego
Copy link
Copy Markdown

Additional vendor extension for Go client generation. No breaking changes. Allows a source type hint to the Go JSON marshaller so JSON string values can be unmarshalled into non-string types.

Allows specification of the source type to the Go JSON marshaller.

Example json: "myValue": "0.10"

YAML:

myValue:
   type: number
      format: double
      x-go-srctype-tag:
      - string

Generated Go code with tag:


MyValue *float64  `json:"myValue,omitempty,string"`

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the [technical committee]

FYI: @ph4r5h4d

Allows specification of the source type to the Go JSON marshaller.

Example json: "myValue": "0.10"

YAML:

myValue:
   type: number
      format: double
      x-go-srctype-tag:
      - string

Generated Go code with tag:

MyValue *float64  `json:"myValue,omitempty,string"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant