Skip to content

Make sure ts-ignore is ignoring right line#14011

Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom
nmalfroy:fix-axios-code-gen
Nov 15, 2022
Merged

Make sure ts-ignore is ignoring right line#14011
macjohnny merged 2 commits intoOpenAPITools:masterfrom
nmalfroy:fix-axios-code-gen

Conversation

@nmalfroy
Copy link
Copy Markdown
Contributor

@nmalfroy nmalfroy commented Nov 14, 2022

As part of PR #13964, a change was introduced that causes Typescript to fail to compile because of unused local variables. This appears to have been a known issue. Moving the ts-ignore comment to fix the issue

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@nmalfroy
Copy link
Copy Markdown
Contributor Author

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

@macjohnny
Copy link
Copy Markdown
Member

@nmalfroy thanks for your contribution.

can you please re-generate the samples?

@nmalfroy
Copy link
Copy Markdown
Contributor Author

Ah right sorry! I didn't realize I needed to merge it in. I added the generated samples

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 7722698 into OpenAPITools:master Nov 15, 2022
@wing328 wing328 added this to the 6.3.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants