[GO] Fix value formatting in url with slices#15581
[GO] Fix value formatting in url with slices#15581wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
|
I am not sure why node3 is failing. The message relates to angular but I have not touched that code section, unless it's a side effect from the go code refresh |
|
@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04) Could I get a review for this and add this to the next releases ? Is there anything missing in the PR ? I don't think the node3 build failures is directly related to this change, but I may be wrong. Could you point me in the right direction if it is linked to my changes ? |
|
thanks for the PR. will try to review this weekend and get it merged |
|
Hi @wing328, |
This is to fix the client generation problem related to #14798 where url value ends up being
reflect.Value+valueinstead of their real value.@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)