Skip to content

[python] Fix incorrect variable name for nullable fields with regex contraints#15623

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
changhc:fix-nullable-regex
May 24, 2023
Merged

[python] Fix incorrect variable name for nullable fields with regex contraints#15623
wing328 merged 1 commit intoOpenAPITools:masterfrom
changhc:fix-nullable-regex

Conversation

@changhc
Copy link
Copy Markdown
Contributor

@changhc changhc commented May 24, 2023

Fixes #15622. This is a tiny fix, so I didn't update the sample spec files to cover this but tested locally. If you consider it's worth updating the spec, I can do that.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether @krjakbrjak I would appreciate your review as member of the technical committee for python. Thanks!

Signed-off-by: Huan-Cheng Chang <changhc84@gmail.com>
@wing328
Copy link
Copy Markdown
Member

wing328 commented May 24, 2023

@changhc thanks for the fix. I'll update the samples if needed.

@wing328 wing328 merged commit 1a483b2 into OpenAPITools:master May 24, 2023
@wing328 wing328 added this to the 7.0.0 milestone May 24, 2023
@changhc changhc deleted the fix-nullable-regex branch May 24, 2023 06:26
@wing328
Copy link
Copy Markdown
Member

wing328 commented May 24, 2023

FYI. Filed #15625 to add a test to catch the issue moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][python] Incorrect variable name for nullable fields with regex contraints

2 participants