Skip to content

[kotlin] Add missing quote in option description#15732

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ctamisier:patch-1
Jun 3, 2023
Merged

[kotlin] Add missing quote in option description#15732
wing328 merged 1 commit intoOpenAPITools:masterfrom
ctamisier:patch-1

Conversation

@ctamisier
Copy link
Copy Markdown
Contributor

@ctamisier ctamisier commented Jun 2, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 3, 2023

@ctamisier thanks for the PR. You will need to update

public static final String SERIALIZATION_LIBRARY_DESC = "What serialization library to use: 'moshi' (default), or 'gson' or 'jackson or 'kotlinx_serialization'";
as well

@ctamisier ctamisier changed the title Update kotlin.md Add missing quote Jun 3, 2023
@wing328 wing328 merged commit 2b9d94c into OpenAPITools:master Jun 3, 2023
@wing328 wing328 changed the title Add missing quote [kotlin] Add missing quote in option description Jun 3, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jun 3, 2023
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 3, 2023

Thanks for the PR, which has been merged. Have a nice weekend.

@ctamisier ctamisier deleted the patch-1 branch June 3, 2023 05:40
@ctamisier
Copy link
Copy Markdown
Contributor Author

No prob, have a nice weekend too !

fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants