Skip to content

Fix dry-run output and add tests#15754

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
Eurofunk:dry-run-states
Jul 2, 2023
Merged

Fix dry-run output and add tests#15754
wing328 merged 1 commit intoOpenAPITools:masterfrom
Eurofunk:dry-run-states

Conversation

@nebulon42
Copy link
Copy Markdown
Contributor

Currently the dry-run status output only shows metadata files. This PR fixes that and also adds tests for the DryRunTemplateManager class.
Fixes #15730.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@nebulon42
Copy link
Copy Markdown
Contributor Author

Not sure what the test failure is about. Locally, I did not have any failures.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 6, 2023

restarted and all tests passed

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 6, 2023

cc @OpenAPITools/generator-core-team

@wing328 wing328 merged commit e2f5997 into OpenAPITools:master Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] dry run output is incomplete

2 participants