Skip to content

[cpp-pistache-server] Adds Recursive model validation#15784

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ventsyv:recursive_model_validation
Jun 15, 2023
Merged

[cpp-pistache-server] Adds Recursive model validation#15784
wing328 merged 1 commit intoOpenAPITools:masterfrom
ventsyv:recursive_model_validation

Conversation

@ventsyv
Copy link
Copy Markdown
Contributor

@ventsyv ventsyv commented Jun 7, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Proposed solution for: #15781
Detailed explanation of the issue is in the ticket.

@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

@ventsyv ventsyv changed the title Adds Recursive model validation [cpp-pistache-server] Adds Recursive model validation Jun 7, 2023
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 8, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@ventsyv
Copy link
Copy Markdown
Contributor Author

ventsyv commented Jun 8, 2023

@wing328 Good catch. I updated it.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 13, 2023

If no further feedback/question, I'll merge it later this week.

@wing328 wing328 merged commit bdeb4ff into OpenAPITools:master Jun 15, 2023
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
@ventsyv ventsyv deleted the recursive_model_validation branch October 24, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants