Skip to content

[Bug] fix: use length to check for default return media type#15833

Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom
mstruebing:mstruebing/fix/15011-media-type
Jun 16, 2023
Merged

[Bug] fix: use length to check for default return media type#15833
macjohnny merged 2 commits intoOpenAPITools:masterfrom
mstruebing:mstruebing/fix/15011-media-type

Conversation

@mstruebing
Copy link
Copy Markdown
Contributor

as mediaTypes is an array of strings and an required argument it will never be undefined when we can rely on the typesystem. However, it can be zero length([]) and in this case we would throw.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

as `mediaTypes` is an array of strings and an required argument
it will never be undefined when we can rely on the typesystem.
However, it can be zero length(`[]`) and in this case we would
throw.

* Closes OpenAPITools#15011
@TiFu
Copy link
Copy Markdown
Contributor

TiFu commented Jun 14, 2023

Thanks for the PR! Change looks good to me.

Could you please re-generate the samples?

@mstruebing
Copy link
Copy Markdown
Contributor Author

@TiFu I've updated the examples.

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 730b946 into OpenAPITools:master Jun 16, 2023
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
…Tools#15833)

* fix: use length to check for default return media type

as `mediaTypes` is an array of strings and an required argument
it will never be undefined when we can rely on the typesystem.
However, it can be zero length(`[]`) and in this case we would
throw.

* Closes OpenAPITools#15011

* chore: update examples
@wing328 wing328 added this to the 7.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Typescript mustache default content-type is not used

5 participants