[Bug] fix: use length to check for default return media type#15833
Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom Jun 16, 2023
Merged
[Bug] fix: use length to check for default return media type#15833macjohnny merged 2 commits intoOpenAPITools:masterfrom
macjohnny merged 2 commits intoOpenAPITools:masterfrom
Conversation
as `mediaTypes` is an array of strings and an required argument it will never be undefined when we can rely on the typesystem. However, it can be zero length(`[]`) and in this case we would throw. * Closes OpenAPITools#15011
Contributor
|
Thanks for the PR! Change looks good to me. Could you please re-generate the samples? |
Contributor
Author
|
@TiFu I've updated the examples. |
176ce98 to
2ba0548
Compare
WassimBenzarti
approved these changes
Jun 15, 2023
fmoraespadtec
pushed a commit
to padteclab/openapi-generator
that referenced
this pull request
Jun 26, 2023
…Tools#15833) * fix: use length to check for default return media type as `mediaTypes` is an array of strings and an required argument it will never be undefined when we can rely on the typesystem. However, it can be zero length(`[]`) and in this case we would throw. * Closes OpenAPITools#15011 * chore: update examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as
mediaTypesis an array of strings and an required argument it will never be undefined when we can rely on the typesystem. However, it can be zero length([]) and in this case we would throw.@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)