Skip to content

[typescript-fetch] fix snakecase discriminator#15838

Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom
Inthememory:typescript-fetch_fix-discriminator
Jun 16, 2023
Merged

[typescript-fetch] fix snakecase discriminator#15838
macjohnny merged 2 commits intoOpenAPITools:masterfrom
Inthememory:typescript-fetch_fix-discriminator

Conversation

@ctjhoa
Copy link
Copy Markdown
Contributor

@ctjhoa ctjhoa commented Jun 13, 2023

Fix #7080

Discriminator should be based on propertyBaseName instead of propertyName like in the following languages: csharp, python, java

I've added reproduction config based on modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @eriktim @stephanpelikan

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Copy Markdown
Contributor

@TiFu TiFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@macjohnny macjohnny merged commit 504744a into OpenAPITools:master Jun 16, 2023
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
* [typescript-fetch] fix snakecase discriminator (OpenAPITools#7080)

* [typescript-fetch] add snakecase discriminator test case
@wing328 wing328 added this to the 7.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [typescript-fetch] Discriminator field transformed from snake_case to CamelCase incorrectly

4 participants