Skip to content

[PHP] fix error on circular references#15900

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
martin-mfg:php-recursion
Jun 27, 2023
Merged

[PHP] fix error on circular references#15900
wing328 merged 3 commits intoOpenAPITools:masterfrom
martin-mfg:php-recursion

Conversation

@martin-mfg
Copy link
Copy Markdown
Contributor

I used this simple OpenApi file - which contains circular references - as input for all generators. This uncovered a problem in 2 php generators. In this PR, I fix this problem.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 27, 2023

LGTM. Thanks for the fix.

@wing328 wing328 merged commit 4bec09f into OpenAPITools:master Jun 27, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants