Skip to content

[csharp][generichost] Add Option struct to enable better validation#15977

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
devhl-labs:15965-better-validation
Jul 3, 2023
Merged

[csharp][generichost] Add Option struct to enable better validation#15977
wing328 merged 2 commits intoOpenAPITools:masterfrom
devhl-labs:15965-better-validation

Conversation

@devhl-labs
Copy link
Copy Markdown
Contributor

Fixes #15965

Operation parameters have both nullable and required properties. To facilitate both, we need the user to tell us their intent. If they give the api a null for a parameter that is not required, we need them to tell us if that null value should be sent to the server or not. If not, then we don't care about the null and we just ignore it.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 7.0.0 milestone Jul 3, 2023
@wing328 wing328 merged commit 00fcaa1 into OpenAPITools:master Jul 3, 2023
@devhl-labs devhl-labs deleted the 15965-better-validation branch July 3, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][csharp] Validation throw ArgumentNullException for nullable argument

2 participants