[BUG] C# Aspnetcore Adding Name property for header parameters#16360
Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom Aug 22, 2023
Conversation
…er-param-missing-Name-property-16275
Member
|
thanks for the PR. can you please follow step 3 in the PR checklist to update the samples so that the CI can verify the change? https://github.com/OpenAPITools/openapi-generator/actions/runs/5915988919/job/16073256078?pr=16360 |
Contributor
Author
|
Sorry for not following the instructions completely. This is first time I make changes here. |
Member
I don't think so. Are you using git bash? I've pushed some commits to update samples and docs. All tests passed. Thanks for the PR. |
Contributor
Author
|
Yes, I used git bash in Windows 10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This defect is similar to #8826. #8826 fixed for path and form parameters in the aspnetcore generator not having the Name= Property set on the attributes but missed header parameters. Missing those results in errors when generating server code from specs that have parameters with underscores or hyphens in their header name.
This PR address the issue #16275
I have tested the fix locally and now the header parameters can have hyphens or underscores and they will be correctly mapped to the Action methods
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)