Skip to content

[BUG] C# Aspnetcore Adding Name property for header parameters#16360

Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom
lance-yuan-igt:aspnetcore-fix-header-param-missing-Name-property-16275
Aug 22, 2023
Merged

[BUG] C# Aspnetcore Adding Name property for header parameters#16360
wing328 merged 5 commits intoOpenAPITools:masterfrom
lance-yuan-igt:aspnetcore-fix-header-param-missing-Name-property-16275

Conversation

@lance-yuan-igt
Copy link
Copy Markdown
Contributor

This defect is similar to #8826. #8826 fixed for path and form parameters in the aspnetcore generator not having the Name= Property set on the attributes but missed header parameters. Missing those results in errors when generating server code from specs that have parameters with underscores or hyphens in their header name.

This PR address the issue #16275
I have tested the fix locally and now the header parameters can have hyphens or underscores and they will be correctly mapped to the Action methods

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 21, 2023

thanks for the PR. can you please follow step 3 in the PR checklist to update the samples so that the CI can verify the change?

https://github.com/OpenAPITools/openapi-generator/actions/runs/5915988919/job/16073256078?pr=16360

@lance-yuan-igt
Copy link
Copy Markdown
Contributor Author

Sorry for not following the instructions completely. This is first time I make changes here.
I did run both scripts and committed/pushed the changes. There're more than 600 files changed, is that normal?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 22, 2023

There're more than 600 files changed, is that normal?

I don't think so. Are you using git bash?

I've pushed some commits to update samples and docs. All tests passed. Thanks for the PR.

@wing328 wing328 merged commit 32fe92f into OpenAPITools:master Aug 22, 2023
@wing328 wing328 added this to the 7.0.0 milestone Aug 22, 2023
@lance-yuan-igt
Copy link
Copy Markdown
Contributor Author

Yes, I used git bash in Windows 10.
Thanks a lot for correcting them for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants