Skip to content

Add mapping features to Julia generators#16370

Merged
wing328 merged 2 commits intomasterfrom
julia-mapping-feature
Aug 24, 2023
Merged

Add mapping features to Julia generators#16370
wing328 merged 2 commits intomasterfrom
julia-mapping-feature

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Aug 21, 2023

Add mapping features (property, parameter model names) to Julia generators (we've added these features to many other generators)

Added a simple test

cc @tanmaykm (2023/01)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@tanmaykm
Copy link
Copy Markdown
Contributor

Thanks for the PR @wing328 . Looks like changes may be needed at more places. Will have more concrete suggestions once I take a closer look.

@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Aug 22, 2023

@tanmaykm thanks for the review. I'll put this on hold for the time being.

@tanmaykm
Copy link
Copy Markdown
Contributor

@wing328 I have made a PR (#16383) to this branch of yours with the additional changes I feel were required. Please take a look.

@wing328 wing328 merged commit 91fc151 into master Aug 24, 2023
@wing328 wing328 deleted the julia-mapping-feature branch August 24, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants