Skip to content

use AxiosRequestConfig type for options in all paths#16821

Open
mastercoms wants to merge 1 commit into
OpenAPITools:masterfrom
mastercoms:patch-1
Open

use AxiosRequestConfig type for options in all paths#16821
mastercoms wants to merge 1 commit into
OpenAPITools:masterfrom
mastercoms:patch-1

Conversation

@mastercoms
Copy link
Copy Markdown

@mastercoms mastercoms commented Oct 13, 2023

In this commit using the type AxiosRequestConfig for the options param was introduced. "Also fixes missing options typing that was any before."

However, one options parameter was seemingly missed. I could not find any documentation or reasoning behind this being kept as any, nor any reverts or anything that affects this line.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant