[Go][Server] Time Parameters in the Path - Bug Fix#17021
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Nov 13, 2023
Merged
[Go][Server] Time Parameters in the Path - Bug Fix#17021wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
This is probably a pretty rare case as it just seems weird to have a time path parameter, but it's good to fix.
lwj5
approved these changes
Nov 12, 2023
Contributor
|
@wing328 good to merge |
jpuerto
pushed a commit
to movementsciences/openapi-generator
that referenced
this pull request
Nov 14, 2023
…penAPITools#17021) This is probably a pretty rare case as it just seems weird to have a time path parameter, but it's good to fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time parameters in the path resulted in code that would not compile as
timewas not imported.Dynamically adding imports into the
controller-api.mustachetemplate based off of what parameter types are used is not implemented so parsing oftimegets handled in therouters.gohelpers.This is probably a pretty rare case as it just seems weird to have a time path parameter, but it's good to fix.
Added an example to the Go-Server Petstore.yaml to show what this looks like.
This was introduced when
timesupport was added in #16749PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@lwj5 @wing328