Skip to content

[Go][Server] Time Parameters in the Path - Bug Fix#17021

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
icubbon:go-server/timeParsingForPathParam
Nov 13, 2023
Merged

[Go][Server] Time Parameters in the Path - Bug Fix#17021
wing328 merged 1 commit intoOpenAPITools:masterfrom
icubbon:go-server/timeParsingForPathParam

Conversation

@icubbon
Copy link
Copy Markdown
Contributor

@icubbon icubbon commented Nov 9, 2023

Time parameters in the path resulted in code that would not compile as time was not imported.
Dynamically adding imports into the controller-api.mustache template based off of what parameter types are used is not implemented so parsing of time gets handled in the routers.go helpers.

This is probably a pretty rare case as it just seems weird to have a time path parameter, but it's good to fix.

Added an example to the Go-Server Petstore.yaml to show what this looks like.

This was introduced when time support was added in #16749

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@lwj5 @wing328

This is probably a pretty rare case as it just seems weird to have a time
path parameter, but it's good to fix.
@lwj5
Copy link
Copy Markdown
Contributor

lwj5 commented Nov 12, 2023

@wing328 good to merge

@wing328 wing328 merged commit 2f655f1 into OpenAPITools:master Nov 13, 2023
@wing328 wing328 added this to the 7.1.0 milestone Nov 13, 2023
jpuerto pushed a commit to movementsciences/openapi-generator that referenced this pull request Nov 14, 2023
…penAPITools#17021)

This is probably a pretty rare case as it just seems weird to have a time
path parameter, but it's good to fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants