Skip to content

[Rust] [Axum] Revert PR #18061#18354

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
linxGnu:revert_pr_18061
Apr 11, 2024
Merged

[Rust] [Axum] Revert PR #18061#18354
wing328 merged 1 commit intoOpenAPITools:masterfrom
linxGnu:revert_pr_18061

Conversation

@linxGnu
Copy link
Copy Markdown
Contributor

@linxGnu linxGnu commented Apr 11, 2024

I found that PR #18061 breaks integration test and @denisbog did not generate/run integration test yet. Reproducing by:

./bin/generate-samples.sh ./bin/configs/manual/*.yaml
 mvn integration-test -f samples/server/petstore/rust-axum/pom.xml

This PR also adapts latest validate crate.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 11, 2024

ok. let's revert that for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants